Skip to content

Use direct force pushes by committing first to a temp branch#70

Open
Andarist wants to merge 10 commits into
mainfrom
temp-branch-strategy
Open

Use direct force pushes by committing first to a temp branch#70
Andarist wants to merge 10 commits into
mainfrom
temp-branch-strategy

Conversation

@Andarist
Copy link
Copy Markdown
Member

No description provided.

Comment thread src/core.ts
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some research to see if we can skip the rest.git.createBlob and call rest.git.createTree directly because the latter accepts contents to upload the blob as string directly, and we can use this most of the time for our usecase. So we don't really need separate API calls.

Obviously, being a general library if we can't assume every change is a text file, so we could add attempts to detect text vs binary and optimize accordingly. Binaries are not common so a few createBlob shouldn't be an issue.

But.. I'm fine with this approach anyway. I think we can explore that later if we want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants