Use a proper class and fix version rendering #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@RileyApeldoorn and @alter2000 can either of you please review? Thanks again for helping me troubleshoot this. Much appreciated. 😄 |
Author
|
@alter2000 Thanks for the review! @OpsBotPrime merge! |
|
Pull request approved for merge by @rudymatela, waiting for rebase behind one pull request. |
Approved-by: rudymatela Auto-deploy: false
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
fix-version-rendering
branch
from
810c7f6 to
8caf09a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #175