Increase event queue sizes and log about dropped events#235
Merged
OpsBotPrime merged 3 commits intomasterfrom Oct 10, 2023
Merged
Increase event queue sizes and log about dropped events#235OpsBotPrime merged 3 commits intomasterfrom
OpsBotPrime merged 3 commits intomasterfrom
Conversation
crtschin
approved these changes
Oct 10, 2023
crtschin
left a comment
crtschin
left a comment
There was a problem hiding this comment.
Nice, might be a good idea to make it configurable to specify the queue sizes via the config so we don't need to make a PR in case this needs to be adjusted further, can you make an issue?
Member
Author
|
Yeah, good idea! I'll get right onto that. @OpsBotPrime merge |
|
Pull request approved for merge by @robbert-vdh, rebasing now. |
Approved-by: robbert-vdh Auto-deploy: false
|
Rebased as 5a27c6f, waiting for CI … |
|
CI job 🟡 started. |
ruuda
reviewed
Oct 12, 2023
| Hoff dropping events when receiving dozens of webhook events at the exact | ||
| same time. | ||
| * When Hoff drops a webhook event because its internal event queue is full, it | ||
| will now log the evenet to STDOUT> |
There was a problem hiding this comment.
s/evenet/event/. Also, is that > supposed to be a .?
robbert-vdh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the chance that webhook events are getting lost when Hoff receives a couple dozen of them in one go. The previous queues were bounded to 10 elements. This increases them to 128 elements, and it prints am message to STDOUT if events are dropped so we can set up alerts for that.
CC @bertptrs