Disallow implicit deployment environment selection#241
Merged
OpsBotPrime merged 3 commits intomasterfrom Oct 26, 2023
Merged
Conversation
robbert-vdh
requested changes
Oct 26, 2023
Member
robbert-vdh
left a comment
robbert-vdh
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have a small style suggestion and it would be nice to have just one more test for merge and deploy on friday (since that test got removed now).
robbert-vdh
approved these changes
Oct 26, 2023
Member
robbert-vdh
left a comment
robbert-vdh
left a comment
There was a problem hiding this comment.
Thanks! Could you also add an entry to the changelog? (I know it's very easy to 😅)
Riscky
force-pushed
the
riscky/deploy-always-env
branch
from
c353fe2 to
50b8ee6
Compare
Author
|
@OpsBotPrime merge |
|
Pull request approved for merge by @Riscky, rebasing now. |
Approved-by: Riscky Auto-deploy: false
|
Rebased as 3ebb989, waiting for CI … |
|
CI job 🟡 started. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disallows
merge and deploywithout specifying an environment, if multiple deployment environments are configured.For repositories with no or a single configured deployment environment, nothing changes.
I added tests for this behavior.