Add and apply the weeder tool #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riscky
approved these changes
Jul 17, 2025
Riscky
left a comment
Riscky
left a comment
There was a problem hiding this comment.
Nice!
CI is failing with a lack of disk space, we might need upgrade to a f1-standard-4
Author
|
Removed some docker stuff to clean up some space. Discussed offline that this is a good solution. @OpsBotPrime merge |
Approved-by: FPtje Priority: Normal Auto-deploy: false
|
Rebased as c60ec53, waiting for CI … |
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
fp/add-weeder
branch
from
b3f51e7 to
c60ec53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weeder is a tool that finds functions that are never used. For a program like Hoff, this is quite nice to have as a check, because it finds all the dead code that no longer needs to be maintained.
It's a quick win to add this and check it on CI 👍
It turns out there were only a couple of dead functions, but to be fair I didn't know that until I installed and ran weeder 😜