Add an endpoint to allow pausing Hoff #295
Conversation
Riscky
force-pushed
the
riscky/pause
branch
from
ab15025 to
f77db1e
Compare
musicismyalibi
left a comment
musicismyalibi
left a comment
There was a problem hiding this comment.
I think the logic looks good. It might be nice to give some sort of feedback when your PR is not merged because of a pause.
That is a good suggestion, although preventing duplicate messages might not be straightforward in this case. I'll think about it. |
src/Server.hs
Outdated
| -- TODO: should probably also be a maybe or bool | ||
| -> (ProjectInfo -> Event -> IO ()) |
There was a problem hiding this comment.
Currently this is a blocking function. We probably want to either change this to not be blocking or explicitly document that this is the case.
|
@OpsBotPrime merge |
|
Rebased as d9594c1, waiting for CI … |
Approved-by: Riscky Priority: Normal Auto-deploy: false
|
CI job 🟡 started. |
|
The build failed ❌. If this is the result of a flaky test, then tag me again with the |
|
seems to be a Semaphore issue, @OpsBotPrime retry |
Approved-by: Riscky Priority: Normal Auto-deploy: false
|
Rebased as 8833aee, waiting for CI … |
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
riscky/pause
branch
from
cbae35e to
8833aee
Compare
3 participants
Implements #253
This adds an endpoint to Hoff to make it possible to pause promotions in a single merge train, and resume operations later.
Prioritized PRs are excluded from the pause.