Add healthcheck endpoint, move metrics endpoint to main port #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riscky
force-pushed
the
riscky/healthcheck
branch
from
d886a3d to
4659bd7
Compare
isomorpheme
reviewed
Oct 24, 2025
isomorpheme
left a comment
isomorpheme
left a comment
There was a problem hiding this comment.
Big +1 on just having the metrics endpoint on the same port and in the same server thread, I think having that separate buys us very little.
Looks good overall, just some style comments, and I think we do want to keep using wai-middleware-prometheus if possible (see other comment).
Riscky
force-pushed
the
riscky/healthcheck
branch
3 times, most recently
from
ca9ff8c to
6867243
Compare
isomorpheme
approved these changes
Oct 28, 2025
| ghQueueFull <- atomically $ isFullTBQueue ghQueue | ||
| projectQueuesFull <- mapM (atomically . isFullTBQueue) $ fmap projectThreadQueue projectThreadState | ||
|
|
||
| return $ not $ ghQueueFull || or projectQueuesFull |
There was a problem hiding this comment.
Reading the || or slightly confused me for a second. I'm not sure if I actually prefer this, but you could skip the || like so:
Suggested change
| return $ not $ ghQueueFull || or projectQueuesFull | |
| return $ not $ or $ ghQueueFull : projectQueuesFull |
Author
There was a problem hiding this comment.
projectQueuesFull isn't a list, so we can't even nicely rewrite this 🙃
Author
|
@OpsBotPrime merge |
Approved-by: Riscky Priority: Normal Auto-deploy: false
|
Rebased as 8780d43, waiting for CI … |
|
CI job 🟡 started. |
OpsBotPrime
force-pushed
the
riscky/healthcheck
branch
from
6867243 to
8780d43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
/healthendpoint, which checks the application health. For now it only checks if the queues are full.I've also moved
/metricsto the main port. I don't think there is a good reason to advertise two separate ports.