Library docs improvements #11
Conversation
Qqwy
left a comment
Qqwy
left a comment
There was a problem hiding this comment.
Thank you for the nice improvements in the documentation, and better formatting <3
| # Individual tests should be very fast. They should never take multiple seconds | ||
| # If after 20sec (accomodating for a toaster-like PC) there is no progress, | ||
| # assume a deadlock | ||
| timeout=20 |
There was a problem hiding this comment.
I guess the CI servers are sometimes a 'toaster-like PC'? 🙈
Are you sure you want to remove the deadlock protection? Maybe bumping this to, say, 60 seconds, would be enough?
There was a problem hiding this comment.
the failure isn't because a deadlock happens, but rather:
/nix/store/c4k9a09j00vp618zs618mpacyp05a15l-python3-3.12.9-env/lib/python3.12/site-packages/_pytest/config/__init__.py:1441: PytestConfigWarning: Unknown config option: timeout
self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")
There was a problem hiding this comment.
The plot thickens: Why does pytest-timeout not get loaded as part of the Nix overlay?
There was a problem hiding this comment.
it's not listed in default.nix like for example pytest-parallel. adding it there also seems to fix the issue
| impl Chunk { | ||
| fn __repr__(&self) -> String { | ||
| format!("{:?}", self) | ||
| format!("{self:?}") |
There was a problem hiding this comment.
Thank you 👍 (for this and all the other places)
There was a problem hiding this comment.
it aint much but its honest work
rlycx
force-pushed
the
rly/docs-improvements
branch
from
7cc9ca1 to
36573c1
Compare
|
@OpsBotPrime merge |
Approved-by: rlycx Priority: Normal Auto-deploy: false
|
Rebased as db579a6, waiting for CI … |
|
CI job 🟡 started. |
3 participants
a couple of things to make the generated docs nicer, at least for the producer module