Clarify consumer log message when chunk reservation expired #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original message was a "todo"/future idea from when opsqueue was more actively being developed. It has a high severity and it sounds actionable to users reading the logs, whereas there isn't really any way they can change the handling. This is a little misleading, so this commit changes the message to be clearer about what's going on.
Qqwy
approved these changes
Oct 20, 2025
Contributor
Qqwy
left a comment
Qqwy
left a comment
There was a problem hiding this comment.
Good change 👍
One thing you could consider however, is whether this should be turned into a debug notice or be kept on info. Since if this message is printed, it is quite likely that the chunk size is too large in a particular usage scenario.
Up to you!
Contributor
Author
|
@OpsBotPrime merge |
Contributor
|
Rebased as 54f9dd9, waiting for CI … |
OpsBotPrime
added a commit
that referenced
this pull request
Oct 23, 2025
Approved-by: rlycx Priority: Normal Auto-deploy: false
Contributor
|
CI job 🟡 started. |
Contributor
|
The build failed ❌. If this is the result of a flaky test, then tag me again with the |
Contributor
Author
|
@OpsBotPrime retry |
Approved-by: rlycx Priority: Normal Auto-deploy: false
Contributor
|
Rebased as 156f0b9, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original message was a "todo"/future idea from when opsqueue was more actively being developed. It has a high severity (error level) and it sounds actionable to users reading the logs, whereas there isn't really any way they can change the handling (because that's deep opsqueue magic). This commit changes the message to be clearer about what's going on.