Latest internal updates #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, only the last 16 bits of the submission_id were used which were in practice nearly always `0`, since there was never more than one submission being generated in the same millisecond (c.f. how Snowflake IDs work). Now, also the higher 64-22=42 bits making up the timestamp are directly involved in the random order, which results in chunks with the same index in different submissions getting wildly different random order numbers.
(Changes are benign; just graph nodes being reordered)
Contributor
Author
|
@OpsBotPrime merge and tag |
Contributor
|
Rebased as a2cb5f1, waiting for CI … |
OpsBotPrime
added a commit
that referenced
this pull request
Aug 4, 2025
Approved-by: Qqwy Priority: Normal Auto-deploy: false
Contributor
|
CI job 🟡 started. |
Contributor
|
The build failed ❌. If this is the result of a flaky test, then tag me again with the |
Contributor
Author
|
@OpsBotPrime merge and tag |
Contributor
|
The build failed ❌. If this is the result of a flaky test, then tag me again with the |
Contributor
Author
|
@OpsBotPrime retry |
Approved-by: Qqwy Priority: Normal Auto-deploy: false
Contributor
|
Rebased as 6724dd1, waiting for CI … |
Contributor
|
CI job 🟡 started. |
Contributor
|
@Qqwy Sorry, I could not tag your PR. Please check the logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes which were done on our internal system but not yet published on the public version.
random_orderis more fair. Before, select chunks of large submissions might sometimes be starved if a queue was very busy.