[feat] Add support for plotting brainunit.Quantity instances in matplotlib#54
Merged
chaoming0625 merged 14 commits intomainfrom Nov 6, 2024
Merged
[feat] Add support for plotting brainunit.Quantity instances in matplotlib#54chaoming0625 merged 14 commits intomainfrom
brainunit.Quantity instances in matplotlib#54chaoming0625 merged 14 commits intomainfrom
Conversation
This commit adds support for importing the `_matplotlib_compat` module in the `brainunit` package. The module is now imported using the wildcard import syntax, allowing easier access to its contents. This change improves the usability and flexibility of the `brainunit` package.
This commit adds a new function `set_axis_unit` to the `_matplotlib_compat` module. This function allows users to set the scale of the specified axis to a target unit in matplotlib plots. It takes parameters such as the axis index, target unit, matplotlib axis object, and precision for adjusting the axis labels. The function also updates the axis label with the target unit. The commit also includes a new test case `test_set_axis_unit` in the `_matplotlib_compat_test` module to verify the functionality of the `set_axis_unit` function.
chaoming0625
requested changes
Oct 29, 2024
Member
chaoming0625
left a comment
chaoming0625
left a comment
There was a problem hiding this comment.
As discussed, we need more unit consistency checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.