Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
brainunit/autograd/_vector_grad.pyandbrainunit/autograd/_vector_grad_test.pyfiles to improve the gradient computation and add new test cases. The most important changes are the modification of the gradient function to handle integerargnumscorrectly and the addition of a new test case for the vector gradient function.Improvements to gradient computation:
brainunit/autograd/_vector_grad.py: Modified thegrad_funfunction to handle integerargnumscorrectly by moving the check and adjustment ofgradsto an earlier point in the function. [1] [2]Enhancements to test coverage:
brainunit/autograd/_vector_grad_test.py: Added a new test casetest_vector_grad_simple2to verify the correctness of the vector gradient function with different units.