Conversation
Co-Authored-By: Cali Dolfi <cdolfi@redhat.com> Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…ttached config item Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Co-Authored-By: mn-ram <235066282+mn-ram@users.noreply.github.com> Signed-off-by: Adrian Edwards <adredwar@redhat.com>
cdolfi
approved these changes
Apr 30, 2026
Contributor
cdolfi
left a comment
cdolfi
left a comment
There was a problem hiding this comment.
lgtm, we have been testing these changes for a bit now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
proxy for augurlabs/augur#3797, which was merged post-fork in the augur repo.
This PR applies the suggested query changes to the two SQL queries that govern what commit changes are pulled in for contributor resolution
It improves upon the changes suggested in augurlabs/augur#3792 and those proposed in the underlying issue by making some small query corrections:
This PR fixes #252
Notes for Reviewers
This has been run locally and appears to work (at least in terms of not crashing) (tested using Augur)
Still waiting to see whether it helps resolve more contributors and get the % of null
cmt_ght_author_id's to be much lower than the 10% observed in both large augur instances.This PR has been merged into the code we deploy in prod for at least a month.
Signed commits