Merged
Conversation
Signed-off-by: Phanindra899 <p14410766@gmail.com>
…n read-only query Signed-off-by: Phanindra899 <p14410766@gmail.com>
MoralCode
changed the title
Contributor
|
Thank you for the review and merge! I enjoyed working on this and would like to continue contributing. Please let me know if there are any areas that need attention. |
1 similar comment
Contributor
|
Thank you for the review and merge! I enjoyed working on this and would like to continue contributing. Please let me know if there are any areas that need attention. |
Contributor
|
@Phanindra899 Yes thank you for contributing and look forward to seeing future PRs. If you have any questions feel free to connect on the CHAOSS slack in the #wg-collectoss-8knot channel or comment on the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a change made by @Phanindra899 originally in augurlabs/augur#3799
It has been rebased
This PR updates transaction handling by applying engine.begin() to a data-modifying DELETE query in tasks.py, ensuring proper commit/rollback behavior in line with SQLAlchemy 2.0 semantics.
The previous change applied to a read-only query in util.py has been reverted, as transaction handling is not required for SELECT operations.
The change is intentionally minimal and scoped to a single DELETE operation to ensure safety and ease of review.
This PR contributes to #230
Notes for Reviewers
Signed commits