Connect Github GraphQL API requests to keyman#415
Merged
Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
This includes using the github REST versions of some of the exceptions Signed-off-by: Adrian Edwards <adredwar@redhat.com>
…he keyman behaviors Signed-off-by: Adrian Edwards <adredwar@redhat.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
i have observed a graphQL task (process_pull_request_files) successfully pauses for the rate limit and then resumes after the reset. Test passed. |
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
MoralCode
added
the
high priority
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the Github GraphQL data access class was still wired up to the old
GithubRandomKeyAuthsystem.This was causing graphQL tasks to continue making requests even after it had exceeded the rate limit, resulting in an exception that crashed the task. The impact of this is that tasks that could not complete within a single API key cycle would never complete and would end up in the daily error retry loop, effectively wasting API key tokens for other tasks running in parallel too.
This PR fixes #409
Notes for Reviewers
This is being tested locally alongside other changes.
Test will be complete when A graphQL task (
process_pull_request_files) successfully pauses for the rate limit and then resumes after the resetSigned commits
Generative AI disclosure
Please select one option:
If AI tools were used, please provide details below:
- What tools were used? minor use of code autocompletion
- Did you review these outputs before submitting this PR? yes, the majority of the code was a copy paste from another branch (fix/facade_none_keys) where some improvements to rate limit behavior were made.