[tasks/github] Batch processing for PR reviews collection#3439
[tasks/github] Batch processing for PR reviews collection#3439sgoggins merged 4 commits intochaoss:mainfrom
Conversation
Signed-off-by: Shlok Gilda <gildashlok@hotmail.com>
MoralCode
left a comment
There was a problem hiding this comment.
Looks good! Im a little hesitant about introducing new functions for inserting things into the DB, but I can see that this was added to deduplicate the code since you need to repeat the call after the batches are processed to get any remaining items that don't fill a full batch.
|
Testing update: Did not encounter any errors. Table values correctly updated. Tested with |
|
@shlokgilda : I merged a PR that fixed a seperate issue on PR reviews from @MoralCode just now ... which created a conflict with your code. I think it looks pretty straightforward as both changes add safety. While I am nearly certain I know how to resolve the conflict while incorporating both changes, I would like @shlokgilda to change it in their fork/branch and update the PR ... So I don't mess something up editing online. |
sgoggins
left a comment
There was a problem hiding this comment.
Just needs the conflict I introduced by merging another PR fixed.
Signed-off-by: Shlok Gilda <gildashlok@hotmail.com>
|
@sgoggins Fixed and pushed. |
|
@shlokgilda : We will merge this as soon as the conflict is resolved! Thanks! |
Signed-off-by: Shlok Gilda <gildashlok@hotmail.com>
|
@sgoggins Merge conflict resolved. |
MoralCode
left a comment
There was a problem hiding this comment.
My comments were addressed. I trust that this has been tested by the author and the code looks reasonable and well documented
Description
collect_pull_request_reviewsto reduce memory usagerepo_iddatabase lookupextract_needed_pr_review_datacall (was storing wrong metadata values)Notes for Reviewers
tool_source, tool_versionwheretool_version, data_sourcewas expected. This didn't crash becausetool_sourceis hardcoded inside the function, but it stored"pull_request_reviews_reviews"astool_versionand"2.0"asdata_sourceinstead of the correct values.collect_pull_requests.Testing
collect_pull_request_reviews. Will post testing related updates in comments if any.Signed commits
AI Disclosure: I used Claude Code to generate docstrings and write this PR draft.