Conversation
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
|
tested and now working |
sgoggins
left a comment
There was a problem hiding this comment.
This one seems to depend on the other one I just reviewed, since its importing it. Lets make sure we merge them both or merge neither of them.
|
theres a dependency in that sense but the two PRs are independent/can be merged in any order since the divide between them is inside vs outside that data access function they dont have to both be merged, but thats what i would strongly recommend doing. the testing i did above was with all 4 prs |
Signed-off-by: Adrian Edwards <adredwar@redhat.com>
to get a better sense of which users cause this hourly task to fail Signed-off-by: Adrian Edwards <adredwar@redhat.com>
|
Pushed additional commits to partially address this failure we are seeing in prod Stack TraceTL;DR it seems like one contributor is returning bad data in a way that raises an exception and isnt caught/skipped by existing logic. I have manually checked a few users to see what the issue could be (my own, the GH ghost user, and a user i know has a private profile) and none returned non-JSON data. The commits i added allow the process to skip and log contributors that demonstrate this error so the task can proceed. Waiting for an oppotunity to redeploy this to our prod and test |
Signed-off-by: Adrian Edwards <17362949+MoralCode@users.noreply.github.com>
Description
in #3748 (comment) @shlokgilda pointed out that A) a bug was preventing the periodic hourly contributor profile refresh task from running, and b) this task was not pulling any useful updated info from the users profile
This PR fixes #3748
Notes for Reviewers
this PR by itself may be broken if #3754 is not also merged - they should be independent as far as merge order though
Signed commits