Sync with master #39
Merged
Sync with master #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
…mit hook for Gitleaks Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
EE-496 (chore): Added secret scan and pre commit hook for whitelisting the repo with security team
…n PR open Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
…d cb-jarunmadhesh; invoke resolveAllComments in isMergeable function Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
Signed-off-by: Jarun Madhesh <124247136+cb-jarunmadhesh@users.noreply.github.com>
Fix reverse merge failing due to cursor bot review comments
cb-anomitromunshi
approved these changes
Aug 26, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const maxRetries = 5 | ||
| let i = 0 | ||
| while (i++ < maxRetries) { | ||
| await resolveAllComments(context, prNumber); |
There was a problem hiding this comment.
Bug: Unnecessary API Calls in Merge Check Loop
Calling resolveAllComments inside the isMergeable retry loop causes it to repeatedly fetch and delete bot comments. This leads to unnecessary API calls (up to 5 times per check) and potential rate limiting, while also adding a side effect to a function meant for checking mergeability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.