Skip to content

Conversation

@mooraby
Copy link
Contributor

@mooraby mooraby commented Jun 25, 2024

No description provided.

Copy link
Contributor

@barsnick barsnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

Comment on lines 92 to 99
do_install() {
install -d ${D}${bindir}
install -m 0755 ${B}/my_module ${D}${bindir}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The do_install() section obviously implies that my_module's cmake does not have a proper installdirective (otherwise it's automatic in bitbake, and everest-cmake also takes care of this). But we'll leave this up to the customer to find out, they have plenty of good links to the Yocto docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just an example to tell the customer that they can overwrite some bitbake functions

Copy link
Contributor

@t-mon t-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions, nice chapter :-)


#. Install the `required packages <https://docs.yoctoproject.org/ref-manual/system-requirements.html#required-packages-for-the-build-host>`_
for Yocto on a Linux machine / virtual machine. (**Note**: We normally set up the Yocto build environment
on an Ubuntu 20.04 or later Linux distribution.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really 20.04 or should we use 24.04 by now...it should not make any difference?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we only tested it until 22.04.. for instance our Jenkins server is definitely not 24.04

@mooraby mooraby requested a review from t-mon June 26, 2024 07:17
Copy link
Contributor

@t-mon t-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Mohannad Oraby added 3 commits June 26, 2024 07:42
Signed-off-by: Mohannad Oraby <mohannad.oraby@chargebyte.com>
Signed-off-by: Mohannad Oraby <mohannad.oraby@chargebyte.com>
Signed-off-by: Mohannad Oraby <mohannad.oraby@chargebyte.com>
@mooraby mooraby merged commit 0daf97a into everest/charge_control_c Jun 26, 2024
@mooraby mooraby deleted the ccc/development branch June 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants