Skip to content

Hardware: Document important interfaces#67

Merged
lategoodbye merged 1 commit intoeverest/charge_somfrom
everest/charge_som_critical_interfaces
Sep 16, 2025
Merged

Hardware: Document important interfaces#67
lategoodbye merged 1 commit intoeverest/charge_somfrom
everest/charge_som_critical_interfaces

Conversation

@lategoodbye
Copy link
Copy Markdown
Member

This adds documentation about CP, PP, CAN, EIA-485 and Ethernet.

@lategoodbye lategoodbye requested a review from mhei September 15, 2025 13:43
@lategoodbye
Copy link
Copy Markdown
Member Author

The only really broken link seems to be "_static/files/chargebyte-keyring.pem", but I didn't touch any related parts.

@mhei
Copy link
Copy Markdown
Member

mhei commented Sep 15, 2025

The keyring links works in CCY documentation on RTD which I updated recently, so I don't understand why it here should be a problem. Let's check this later once we updated/rebuilt the pages.
I like this change, just a nit: I prefer to write all important words in headlines with upper letters, also in tables, here for example "EIA-485 interfaces" -> "EIA-485 Interfaces" or "Board interfaces" ... but this is a personal taste, feel free to leave and merge as-is.

@lategoodbye lategoodbye force-pushed the everest/charge_som_critical_interfaces branch from 13bb890 to 4dd5b3b Compare September 16, 2025 09:52
This adds documentation about CP, PP, CAN, EIA-485 and Ethernet.

Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
@lategoodbye lategoodbye force-pushed the everest/charge_som_critical_interfaces branch from 4dd5b3b to fe037ed Compare September 16, 2025 09:56
@lategoodbye lategoodbye merged commit 7273d02 into everest/charge_som Sep 16, 2025
1 check failed
@lategoodbye lategoodbye deleted the everest/charge_som_critical_interfaces branch September 18, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants