Charge SOM: update DBC and add Safety Controller Parameterization #76
Conversation
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
mhei
requested review from
FaHaGit,
barsnick,
lategoodbye and
stefannagelchargebyte
|
|
||
| Since the open/close timings make no sense in case of `disabled` or `without-feedback`, it is possible to use these | ||
| tokens directly as array item (actually, it is also possible to use the `with-feedback...` ones, but then the timings | ||
| are considered zero). |
There was a problem hiding this comment.
Sorry, I'm not sure about the intention of this paragraph. Do you just want to say that close-time & open-time are optional and preinitialized with 0? In case of "with-feedback" it wont work because of the physics of a contactor, right?
There was a problem hiding this comment.
If you dont use feedback, the open/close times can be any value.
If you use feedback and leave the open/close time empty ... they will be 0 which will not work.
Maybe you can write:
Since the open/close timings make no sense in case of disabled or without-feedback, it is possible to use these
tokens directly as array item (actually, it is also possible to use the with-feedback... ones, but then the timings
are considered zero which will result in an error due to the latency in the contactor).
|
|
||
| - 0x0 = NormalState | ||
| - 0x1 = SafeState | ||
| - 0x3 = SNA |
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
No description provided.