Fix: Detect erroneous multiplication assignments (x *= y) #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses a gap where multiplication assignments were not checked:
I recommend this linter occasionally, but
zimpenfishpointed out it missed this case in some of their code: https://lobste.rs/c/7pbivgPS: I updated
go.modto 1.16. We have a dependency ongolang.org/x/tools@v0.6.0, which usesio.ReadAll. The dependency itself declaresgo 1.18 // tagx:compat 1.16, but figured I'd avoid upping the requirement more than necessary.Test Plan
Using Docker because the tests are broken with Go binaries >= 1.22, but that's not our fault: golang/go#75918 (comment)