[pylint] invalid-characters-*

[r3m0t]

No description provided.

[github-actions]

✅ ecosystem check detected no changes.

[MichaReiser]

Neat!

We can improve the ergonomics (reduce the amount of & a caller must write) by:

1. Change Rule to implement Copy (Rule is only 2 bytes large, which is cheaper than passing a reference that is 8 bytes) by changing the derive macro here Edit: see refactor: Add Copy implementation to Rule #3556
2. Accept any iterable

Suggested change

	pub fn any_enabled(&self, codes: &[&Rule]) -> bool {
	codes.iter().any(|c| self.enabled.contains_key(c))
	}
	pub fn any_enabled(&self, codes: impl IntoIterator<Item=Rule>) -> bool {
	codes.into_iter().any(|c| self.enabled.contains_key(c))
	}

You can then use it like this

let enforce_ambiguous_unicode_character = settings.rules.any_enabled([
        Rule::AmbiguousUnicodeCharacterString,
        Rule::AmbiguousUnicodeCharacterDocstring,
        Rule::AmbiguousUnicodeCharacterComment,
    ]);

[MichaReiser]

Nit: Use any_enabled?

[github-actions]

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     13.7±0.07ms     3.0 MB/sec    1.01     13.8±0.06ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.6±0.02ms     4.6 MB/sec    1.00      3.6±0.01ms     4.6 MB/sec
linter/all-rules/numpy/globals.py          1.00    500.7±1.06µs     5.9 MB/sec    1.00    501.6±1.28µs     5.9 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.1±0.02ms     4.2 MB/sec    1.00      6.1±0.02ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.00      7.6±0.03ms     5.4 MB/sec    1.01      7.6±0.02ms     5.3 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1682.3±2.35µs     9.9 MB/sec    1.01   1704.6±1.41µs     9.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    193.2±0.47µs    15.3 MB/sec    1.01    195.3±1.55µs    15.1 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.5±0.01ms     7.3 MB/sec    1.02      3.6±0.01ms     7.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.0±0.14ms     2.5 MB/sec    1.00     15.9±0.15ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.05ms     3.9 MB/sec    1.00      4.2±0.10ms     3.9 MB/sec
linter/all-rules/numpy/globals.py          1.01    543.2±8.31µs     5.4 MB/sec    1.00    538.5±5.52µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.0±0.07ms     3.6 MB/sec    1.00      7.0±0.06ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      9.0±0.08ms     4.5 MB/sec    1.01      9.1±0.07ms     4.5 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1957.9±23.64µs     8.5 MB/sec    1.00  1953.3±15.28µs     8.5 MB/sec
linter/default-rules/numpy/globals.py      1.00    213.3±3.94µs    13.8 MB/sec    1.02    217.3±9.23µs    13.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      4.1±0.04ms     6.2 MB/sec    1.01      4.2±0.17ms     6.1 MB/sec

[charliermarsh]

Sorry for the delay, will get to this tomorrow.