This repository was archived by the owner on Mar 6, 2025. It is now read-only.
serve: add --health-port flag#52
Merged
Merged
Conversation
Fixes health port type also, now being consistent with SSH and HTTP port types.
Contributor
Author
|
Not strictly necessary I guess, as the port can be configured via ENV, but makes it a bit more discoverable. The stats port is also missing, but charm doesn't seem to be using it for anything currently. |
toby
approved these changes
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes health port type also, now being consistent with SSH and HTTP port
types.