fix: don't strip newlines in error messages#86
Merged
meowgorithm merged 4 commits intomainfrom Mar 11, 2026
Merged
Conversation
ccoVeille
reviewed
Mar 7, 2026
meowgorithm
force-pushed
the
newline-fix
branch
2 times, most recently
from
cf11e46 to
c23784c
Compare
ccoVeille
reviewed
Mar 7, 2026
| if len(words) == 0 { | ||
| // Find the first word, skipping any leading whitespace. | ||
| start := 0 | ||
| for start < len(s) && unicode.IsSpace(rune(s[start])) { |
There was a problem hiding this comment.
Are you sure you want all space characters included in the IsSpace?
Or would you like to limit yourself to \n\r\t and space?
Member
Author
There was a problem hiding this comment.
That would be more predictable, though technically speaking this is inline with the former behavior. Could go either way here.
aymanbagabas
reviewed
Mar 9, 2026
meowgorithm
force-pushed
the
newline-fix
branch
2 times, most recently
from
ca98ba9 to
c442561
Compare
andreynering
approved these changes
Mar 10, 2026
aymanbagabas
approved these changes
Mar 10, 2026
ccoVeille
approved these changes
Mar 10, 2026
Co-authored-by: Ayman Bagabas <ayman.bagabas@gmail.com>
meowgorithm
force-pushed
the
newline-fix
branch
from
30b526e to
4001323
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some behavior where newlines would be stripped in error messages.
Before:
After: