Skip to content

CkPupPerPlaceData(): set numObjects correctly. #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

CkPupPerPlaceData(): set numObjects correctly. #3899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b06f315
CkPupPerPlaceData(): set numObjects correctly.
trquinn Jul 2, 2025
a917fc8
White space cleanup.
trquinn Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/ck-core/ckcheckpoint.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,12 +555,6 @@ static void CkPupPerPlaceData(PUP::er &p, GroupIDTable *idTable, GroupTable *obj
numGroups = idTable->size();
}
p|numGroups;
if (p.isUnpacking()) {
if(CkMyPe()==0)
numObjects = numGroups+1;
else
numObjects = 1;
}
DEBCHK("[%d] CkPupPerPlaceData %s: numGroups = %d\n", CkMyPe(),p.typeString(),numGroups);

std::vector<GroupInfo> tmpInfo(numGroups);
Expand All @@ -580,6 +574,7 @@ static void CkPupPerPlaceData(PUP::er &p, GroupIDTable *idTable, GroupTable *obj
}
p|tmpInfo;

int maxGroup = 0;
for (i = 0; i < numGroups; i++)
{
if (!tmpInfo[i].present)
Expand All @@ -599,6 +594,8 @@ static void CkPupPerPlaceData(PUP::er &p, GroupIDTable *idTable, GroupTable *obj
{
creationFn(gID, eIdx, env);
}
if(gID.idx > maxGroup)
maxGroup = gID.idx;

CkFreeSysMsg(m);
} // end of unPacking
Expand All @@ -608,6 +605,13 @@ static void CkPupPerPlaceData(PUP::er &p, GroupIDTable *idTable, GroupTable *obj
// if using migration constructor, you'd better have a pup
gobj->virtual_pup(p);
}

if (p.isUnpacking()) {
if(CkMyPe()==0)
numObjects = maxGroup+1;
else
numObjects = 1;
}
}

void CkPupGroupData(PUP::er &p
Expand Down