Skip to content

Fix ast calls in wait.py for python 3.14#306

Merged
ritvikrao merged 7 commits intomainfrom
wait-ast-fix
Apr 29, 2026
Merged

Fix ast calls in wait.py for python 3.14#306
ritvikrao merged 7 commits intomainfrom
wait-ast-fix

Conversation

@ritvikrao
Copy link
Copy Markdown
Collaborator

In Python 3.8, the ast.Num class was deprecated, and the class was removed in Python 3.14. This means that Charm4Py programs won't work with Python 3.14. This fixes that error by replacing ast.Num with the correct ast.Constant implementation.

@ritvikrao ritvikrao requested review from adityapb and lvkale April 29, 2026 14:54
Copy link
Copy Markdown

@lvkale lvkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward. We continue to support 3.10 onwards right?

@ritvikrao
Copy link
Copy Markdown
Collaborator Author

Seems straightforward. We continue to support 3.10 onwards right?

Yes

@ritvikrao ritvikrao merged commit 53df41d into main Apr 29, 2026
11 checks passed
@ritvikrao ritvikrao deleted the wait-ast-fix branch April 29, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants