Browserify build system #2007
Merged
Browserify build system #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
😮 nice! Not sure what the test failures are, but this would be great. @davis you might be interested in this |
Possible usages are: src/Chart.js (umd) dist/Chart.js (ChartJS) dist/Chart.min.js (ChartJS minified) dist/Chart.bundle.js (ChartJS with Moment.js) dist/Chart.bundle.min.js (ChartJS with Moment.js minified)
Contributor
Author
|
Closes #1898 |
Contributor
Author
|
Closes #1873 |
Contributor
Author
|
Closes #1479 |
This was referenced Feb 12, 2016
Closed
|
Looks like this branch addresses #1989 too. |
Member
|
Might also address #1847 |
Member
|
Only thing I'd suggest adding to this is some samples & docs. Maybe show a sample where we pull it in with requireJS. It would also be great to have something in the docs about using it with require / browserify / webpack since it's a fairly common question that we get. |
Contributor
|
nice! |
Member
|
@tannerlinsley doc updates look good. you can go ahead and merge any-time then close out the above issues 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible usages are:
src/Chart.js (umd)
dist/Chart.js (vanilla)
dist/Chart.min.js (vanilla minified)
dist/Chart.bundle.js (vanilla with Moment.js)
dist/Chart.bundle.min.js (vanilla with Moment.js minified)