spanGaps does not work well

[hongbo-miao]

I am using v2.1.6

I tried to create continuous line when there is a null point in the middle.

However, it does not work well in some situations.
For example

  {
    label: "A random label",
    data: [20, 30, 80, 90, 50, null, 30],
    spanGaps: true
  }

    {
      label: "A random label",
      data: [20, 30, 80, 90, null, 20, 30],
      spanGaps: true
    }

[neilmacintyre]

@etimberg I would like to work on this issue any recommendations on where to start file wise, if no one else is not working on it already.

[neilmacintyre]

Looking at it now this and should not be too hard to fix. It only occurs when the line tension is at to something that is not equal to 0 which leads me to believe it is an issue the way the if statements are setup in this code.

else if (point._view.tension === 0) {
                ctx.lineTo(point._view.x, point._view.y);
            } else {
                // Line between points
                ctx.bezierCurveTo(
                    previousPoint._view.controlPointNextX,
                    previousPoint._view.controlPointNextY,
                    point._view.controlPointPreviousX,
                    point._view.controlPointPreviousY,
                    point._view.x,
                    point._view.y
                );
            }

I will continue looking it to this and try to fix it :)

[etimberg]

@nmac143 feel free to work on this :)

[hongbo-miao]

@eemikula thanks! works well now!