Update codeclimate.yml #4654
Merged
Update codeclimate.yml #4654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
approved these changes
Aug 13, 2017
Member
simonbrunel
left a comment
simonbrunel
left a comment
There was a problem hiding this comment.
Good catch by removing useless file from the CC reports.
| paths: | ||
| - "src/**/*.js" | ||
| exclude_paths: | ||
| - dist/**/* |
Member
There was a problem hiding this comment.
I think it's safer to keep dist/ since this folder is pushed in tags - in case we want CC score for releases.
benmccann
reviewed
Aug 14, 2017
| - coverage/**/* | ||
| - '.github/' | ||
| - 'dist/' | ||
| - 'test/' |
Contributor
There was a problem hiding this comment.
I think it'd make sense to run code climate on the test code
Contributor
Author
There was a problem hiding this comment.
This change isn't removing scores for tests on codeclimate, as they were never scored before (Lines 13-14). This is just removing them from showing up on codeclimate without any score.
As far as running codeclimate on the tests, I think it would just add a whole host of problems that we can't do anything about because tests have a very repetitive structure.
etimberg
approved these changes
Aug 14, 2017
silverspectro
pushed a commit
to silverspectro/Chart.js
that referenced
this pull request
Aug 21, 2017
* Update codeclimate.yml * Update .codeclimate.yml
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
* Update codeclimate.yml * Update .codeclimate.yml
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Update codeclimate.yml * Update .codeclimate.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates codeclimate to only include files that are actually being scored. Currently there are many files that do not contribute to the overall score (such as markdown docs) but they add clutter to the codeclimate interface. This change removes those documents from showing up on codeclimate.