Skip to content

Update codeclimate.yml #4654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2017
Merged

Update codeclimate.yml #4654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdbe841
Update codeclimate.yml
panzarino Aug 13, 2017
b395cb7
Update .codeclimate.yml
panzarino Aug 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .codeclimate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ engines:
config:
languages:
- javascript
exclude_paths:
- "samples/samples.js"
eslint:
enabled: true
channel: "eslint-3"
Expand All @@ -15,7 +13,13 @@ ratings:
paths:
- "src/**/*.js"
exclude_paths:
- dist/**/*
Copy link
Member

@simonbrunel simonbrunel Aug 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's safer to keep dist/ since this folder is pushed in tags - in case we want CC score for releases.

Copy link
Contributor Author

@panzarino panzarino Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

- node_modules/**/*
- test/**/*
- coverage/**/*
- '.github/'
- 'dist/'
- 'test/'
Copy link
Contributor

@benmccann benmccann Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd make sense to run code climate on the test code

Copy link
Contributor Author

@panzarino panzarino Aug 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't removing scores for tests on codeclimate, as they were never scored before (Lines 13-14). This is just removing them from showing up on codeclimate without any score.

As far as running codeclimate on the tests, I think it would just add a whole host of problems that we can't do anything about because tests have a very repetitive structure.

- 'docs/'
- 'samples/'
- 'scripts/'
- '**.md'
- '**.json'
- 'gulpfile.js'
- 'karma.conf.js'