fix(animation): strip CSS comments from color strings before interpolation#12189
Open
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Open
fix(animation): strip CSS comments from color strings before interpolation#12189jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Conversation
…ation When color values contain CSS comments like 'rgba(255,0,0, /*alpha*/ 0.5)', the color interpolator would fail to parse them correctly, causing color transitions to not animate smoothly. This fix strips CSS /* ... */ comments from color strings before passing them to the color parser, allowing transitions to work even with commented color values. Fixes chartjs#12079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12079
When color strings contain CSS-style comments (e.g.,
rgba(255, 0, 0 /* red */, 0.5)), the color interpolation during animation would fail because the color helper couldn't parse the commented string.Changes
stripCssCommentshelper function to remove/* ... */style comments from color stringsUse Case
Some users document their colors inline using CSS comments, which is valid CSS but wasn't being handled by Chart.js's animation system:
backgroundColor: 'rgba(255, 0, 0 /* red */, 0.5)'This fix ensures such colors can still be animated properly.