Moved moment to peerDependencies #4986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm not sure this is necessary or the best fix for this issue. The issue should already be resolved by #4891 once Chart.js 2.8.0 is released |
Author
|
@benmccann The issue I am experiencing with a webpack based build process seems to be centered around the fact that moment gets installed under the Chart.js folder structure in node_modules. Webpack would include the module twice. Once I moved that out to peer dependencies, moment was only included once. I could probably solve this in my webpack.config, but moving it to peerDependencies seems to be a better solution IMHO. |
Contributor
|
Are you using Webpack 1 or 2? Can you try using DedupePlugin instead? |
Contributor
|
closing due to inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple change to help prevent double inclusion of moment in client build processes