Skip to content

Conversation

@benmccann
Copy link
Contributor

@benmccann benmccann commented Dec 19, 2019

There are a few issues being fixed here:

  • getPixelForTick was returning the wrong value when autoSkip was enabled because it was using a cached view of the ticks instead of the remaining ticks
  • The callback was deleting labels off ticks, but leaving the ticks in place. This made it really hard for the autoSkipper to work properly because the autoSkipper would then remove some ticks and you'd be left with a strange assortment of labels being left after both the callback and autoSkipper were done. We should just let the autoSkipper handle it. Basically the callback was trying to implement something like major ticks, so I just turned major ticks on and let the autoSkipper do it's thing. It works much better now
  • autoSkip sometimes generated undefined ticks. I added a call to Math.round to fix
  • The log scale was generating strange series of ticks. E.g. one of the tests checked to see that the generated ticks were "0, 9, 10, 20, 30". That's really strange in my opinion

@kurkle
Copy link
Member

kurkle commented Dec 19, 2019

FYI, builds are failing

@ac-arecabay
Copy link

Thank you @benmccann - appreciate the fix 👍

@benmccann
Copy link
Contributor Author

The build is passing now and I made some more improvements as well

@etimberg etimberg merged commit fc158ee into chartjs:master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants