You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hmm, that issue is saying that there's an inconsistency between the legend and title fontSize where legend accepts a string and title doesn't. From a glance at the code, I don't see where legend accepts a string, so we might want to make sure that it still does and we're not introducing an inconsistency here. But if it does, I'd probably go the other direction and make legend fontSize only accept number. I'm not sure I want to find every option that takes a number and make sure they all work with string
I don't think either accept a string before this PR. They may have previously done so, but _parseFont couldn't handle it so if the title supported a string it was broken before. Since all font parsing is done with _parseFont, I think any font size could now be a string
In terms of accepting or rejecting invalid parameters, I'm not sure what options we have. We'd need some kind of pass to reject these and spit out useful error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6373