Skip to content

Conversation

@keith-chartmogul
Copy link
Contributor

@keith-chartmogul keith-chartmogul commented May 19, 2025

This PR fixes an issue with the Tasks API schema, specifically ensuring that the task_uuid property is returned in task responses instead of uuid. Resolves #112.

Copy link
Contributor

@briwa briwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've also made a small edit to the PR description. See this doc

Details

Screenshot 2025-05-19 at 11 21 36 AM

@briwa
Copy link
Contributor

briwa commented May 19, 2025

Also @keith-chartmogul you might want to bump the version in this PR too, similar to how you did it in #109, i.e. b17ef74

Copy link

@geopet85 geopet85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but why raise the version to 4.6.2 since 4.6.1 was not tagged or released to pypi? Perhaps we can combine altogether?

@keith-chartmogul
Copy link
Contributor Author

Also @keith-chartmogul you might want to bump the version in this PR too, similar to how you did it in #109, i.e. b17ef74

Good call, I updated the version number to 4.7.0 and adjusted the changelog as well. And thanks for adjusting the PR description to automatically close the issue raised by George.

@briwa @geopet85 Pushing another commit does not clear the original approval, so I just want to get a re-approval in case I misunderstood Briwa's suggestion. Thanks for understanding. 🙏

@briwa
Copy link
Contributor

briwa commented May 19, 2025

@keith-chartmogul Let's go with George's suggestion to release it as 4.6.1 (as opposed to what you did 4.7.0) -- the unreleased code is mostly fixes and improvements IMO, so it should be a patch upgrade instead of a minor upgrade

Copy link
Contributor

@briwa briwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that's left after updating the changelog below is just to push the tag v4.6.1 and afaik the new tag should be added in pypi as well

CHANGELOG.md Outdated
Comment on lines 11 to 15
## [4.7.0] - 2025-05-19
- Fixed Tasks API schema issue

## [4.6.1] - unreleased
- Unify requirements in a single place
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [4.7.0] - 2025-05-19
- Fixed Tasks API schema issue
## [4.6.1] - unreleased
- Unify requirements in a single place
## [4.6.1] - 2025-05-19
- Fix Tasks API schema issue
- Unify requirements in a single place

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I meant. 4.6.1 should be the target version IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion guys 🫠

I've updated to @briwa's suggestion above and amended version.py as well. No need for any more re-approvals as it is clear what was being asked now. I'll merge the PR as it currently is and release right away. 🫡

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 5eb04aa and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 98.5% (0.0% change).

View more on Code Climate.

@keith-chartmogul keith-chartmogul merged commit 5f175e7 into main May 19, 2025
7 checks passed
@keith-chartmogul keith-chartmogul deleted the kd/sc-67784/fix_tasks_api_schema_issue branch May 19, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UUID is not returned in tasks endpoints

5 participants