-
Notifications
You must be signed in to change notification settings - Fork 9
Fix Tasks API Schema Mismatch Issue [sc-67784] #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tasks API Schema Mismatch Issue [sc-67784] #113
Conversation
briwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've also made a small edit to the PR description. See this doc
|
Also @keith-chartmogul you might want to bump the version in this PR too, similar to how you did it in #109, i.e. b17ef74 |
geopet85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor but why raise the version to 4.6.2 since 4.6.1 was not tagged or released to pypi? Perhaps we can combine altogether?
Good call, I updated the version number to @briwa @geopet85 Pushing another commit does not clear the original approval, so I just want to get a re-approval in case I misunderstood Briwa's suggestion. Thanks for understanding. 🙏 |
|
@keith-chartmogul Let's go with George's suggestion to release it as |
briwa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All that's left after updating the changelog below is just to push the tag v4.6.1 and afaik the new tag should be added in pypi as well
CHANGELOG.md
Outdated
| ## [4.7.0] - 2025-05-19 | ||
| - Fixed Tasks API schema issue | ||
|
|
||
| ## [4.6.1] - unreleased | ||
| - Unify requirements in a single place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ## [4.7.0] - 2025-05-19 | |
| - Fixed Tasks API schema issue | |
| ## [4.6.1] - unreleased | |
| - Unify requirements in a single place | |
| ## [4.6.1] - 2025-05-19 | |
| - Fix Tasks API schema issue | |
| - Unify requirements in a single place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I meant. 4.6.1 should be the target version IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion guys 🫠
I've updated to @briwa's suggestion above and amended version.py as well. No need for any more re-approvals as it is clear what was being asked now. I'll merge the PR as it currently is and release right away. 🫡
|
Code Climate has analyzed commit 5eb04aa and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 98.5% (0.0% change). View more on Code Climate. |

This PR fixes an issue with the Tasks API schema, specifically ensuring that the
task_uuidproperty is returned in task responses instead ofuuid. Resolves #112.