refactor: update prometheus metrics config#38
refactor: update prometheus metrics config#38nerdeveloper wants to merge 3 commits intochartmuseum:mainfrom
Conversation
cbuto
left a comment
cbuto
left a comment
There was a problem hiding this comment.
thanks! 🎉 A few small changes needed but looks good.
Also, we’ll need to bump the chart version. Should this be a major version bump since this results in breaking changes @jdolitsky? Not sure how this was handled in the past!
| DISABLE_STATEFILES: false | ||
| # disable Prometheus metrics | ||
| DISABLE_METRICS: true | ||
| ENABLE_METRICS: false |
| # disable use of index-cache.yaml | ||
| DISABLE_STATEFILES: false | ||
| # disable Prometheus metrics | ||
| DISABLE_METRICS: true |
There was a problem hiding this comment.
💭 I wonder if we should leave this here for a release so the depreciation warning is printed? Then remove it in a subsequent release?
There was a problem hiding this comment.
yea.. I am wondering if we should merge this now or wait until v0.15.0 is released. I suppose people could use this chart with canary / main, so perhaps we keep the old env var here for the time being
There was a problem hiding this comment.
I want to believe this should have a milestone attached, Lmk if you want me to refactor this back to what it was.
There was a problem hiding this comment.
@nerdeveloper @jdolitsky I feel like we should wait for v0.15.0 to be released, otherwise it might be a bit weird for both the ENABLE_METRICS and the DISABLE_METRICS config options to exist together.
jdolitsky
left a comment
jdolitsky
left a comment
There was a problem hiding this comment.
Can we bump the chart version to 3.7.0 ?
Sure I can do that |
Co-authored-by: Casey Buto <cbuto22@gmail.com>
|
Also, Please do I need to update this content: https://github.com/chartmuseum/www/blob/main/content/docs/prometheus-metrics/_index.md? cc @cbuto @jdolitsky |
yep! any docs that reference the metrics config should be updated (but only merged after 0.15.0 is released) |
|
@jdolitsky @cbuto I have opened PR and made changes to the website. Kindly check it out: chartmuseum/www#14 |
|
@nerdeveloper can you rebase this with main and update the chart version? I think this change will actually have in include the image bump as well when its time since its a breaking change |
|
handled in another PR |
3 participants
Update Prometheus metric config from DISABLE_METRICS: true to ENABLE_METRICS: false