Compress avatar to below 20k #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Hocuri
force-pushed
the
chat-user-avatar-base64-20kb
branch
from
d35795a to
f79c652
Compare
link2xt
reviewed
May 1, 2021
link2xt
reviewed
May 1, 2021
…ve the problem that JPEGs are saved as PNGs now though
10 tasks
link2xt
approved these changes
May 2, 2021
src/blob.rs
Outdated
| mut blob_abs: PathBuf, | ||
| mut img_wh: u32, | ||
| max_bytes: Option<usize>, | ||
| ) -> Result<String, BlobError> { |
Collaborator
There was a problem hiding this comment.
I think it's better to explicitly return Option<String> and use None instead of special empty string value.
Collaborator
There was a problem hiding this comment.
I have pushed this change to this branch
Hocuri
changed the title
Contributor
|
nice, just sent avatars with outlook :) |
This was referenced Jun 5, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, group images are compressed as well because it was easier to implement that way.
Currently, in the unlikely case that the avatar is compressed down to 20x20 pixels but still bigger than 20KB, the user doesn't get any indication of this, the avatar simply isn't changed (at least on Android).
If we want to change this, the easiest way is probably to let
dc_set_config()in the ffi callerror!()ifSelfavatarcan't be set. The same might make sense for some or all other configs. BUUUUUT: At least Android doesn't show error!() toasts anymore, probably because they were used too often and too spammy.The factor by which we scale down if the file is too big is 1.5.
I hope everything is clear 😂 there were surprisingly many small problems.