Skip to content

Pause I/O in get_backup()#4177

Merged
flub merged 1 commit intomasterfrom
link2xt/get-backup-pause
Mar 20, 2023
Merged

Pause I/O in get_backup()#4177
flub merged 1 commit intomasterfrom
link2xt/get-backup-pause

Conversation

@link2xt
Copy link
Copy Markdown
Collaborator

@link2xt link2xt commented Mar 19, 2023 •
edited by flub
Loading

#skip-changelog

@link2xt link2xt requested a review from r10s March 19, 2023 19:07
@link2xt link2xt mentioned this pull request Mar 19, 2023
Closed
r10s
r10s approved these changes Mar 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming the guard is only needed during creation of the backup provider - and not during the actual transfer, this lgtm.

@flub
Copy link
Copy Markdown
Contributor

flub commented Mar 19, 2023

BackupProvider::prepare also needs a paus_io call

@flub
Copy link
Copy Markdown
Contributor

flub commented Mar 19, 2023

and watch_provider is the one that should do the resuming

@flub
Copy link
Copy Markdown
Contributor

flub commented Mar 19, 2023

(i can do this tomorrow if you like)

@flub flub mentioned this pull request Mar 20, 2023
Closed
25 tasks
@flub flub merged commit 5d80d47 into master Mar 20, 2023
@flub flub deleted the link2xt/get-backup-pause branch March 20, 2023 09:25
@r10s r10s mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flub flub flub approved these changes

@r10s r10s r10s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@link2xt @flub @r10s