fix: jsonrpc: typescript client: fix types of events in event emitter#4373
Merged
Simon-Laux merged 2 commits intomasterfrom May 9, 2023
Merged
fix: jsonrpc: typescript client: fix types of events in event emitter#4373Simon-Laux merged 2 commits intomasterfrom
Simon-Laux merged 2 commits intomasterfrom
Conversation
adbenitez
approved these changes
May 5, 2023
Collaborator
|
CI is failing |
Member
Author
works locally for me so I'm a bit confused here Edit: somehow the ci already uses Typescript 5 while the package.json specifies version 4. I can reproduce this now |
adbenitez
reviewed
May 8, 2023
doing the types right via casting is to complicated IMO and has no real benefit here.
Simon-Laux
force-pushed
the
jsonrpc-ts-fix-event-listener-types
branch
from
cca235c to
a67edb1
Compare
adbenitez
approved these changes
May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.