Conversation
If a contact's key changed since the verification, then it's very unlikely that they still have the old, verified key. So, don't show them as verified anymore. This also means that you can't add a contact like this to a verified group, which is good. The documentation actually already described this (new) behavior: ```rust /// and if the key has not changed since this verification. ``` so, this adapts the code to the documentation.
adbenitez
approved these changes
Jul 25, 2023
Collaborator
adbenitez
left a comment
adbenitez
left a comment
There was a problem hiding this comment.
really nice improvement <3
link2xt
approved these changes
Jul 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a contact's key changed since the verification, then it's very unlikely that they still have the old, verified key. So, don't show them as verified anymore.
This also means that you can't add a contact like this to a verified group, which is good.
The documentation actually already described this (new) behavior:
/// and if the key has not changed since this verification.so, this adapts the code to the documentation.