Skip to content

docs: refine Contact::get_verifier_id and Contact::is_verified documentation#4922

Merged
link2xt merged 2 commits intomainfrom
refine-verifier-docs
Nov 3, 2023
Merged

docs: refine Contact::get_verifier_id and Contact::is_verified documentation#4922
link2xt merged 2 commits intomainfrom
refine-verifier-docs

Conversation

@r10s
Copy link
Copy Markdown
Contributor

@r10s r10s commented Nov 3, 2023

No description provided.

@link2xt link2xt changed the title refine documentation about verifier docs: refine Contact::get_verifier_id and Contact::is_verified documentation Nov 3, 2023
@link2xt link2xt requested a review from Simon-Laux November 3, 2023 21:01
Copy link
Copy Markdown
Contributor Author

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

* in the title of the contact profile,
* in contact list items and in chat member list items.
*
* Do not use this function when displaying profile view contents.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Do not use this function when displaying profile view contents.
* Do not use this function when displaying profile view "Introduced by" contents.

i would be more precise here, as in the profile's title bar, using is_verified() is fine (to be consistent with lists)

@link2xt link2xt merged commit c600bfa into main Nov 3, 2023
@link2xt link2xt deleted the refine-verifier-docs branch November 3, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants