feat: Ratelimit IMAP connections (#4940)#5061
Merged
Conversation
Limit the number of IMAP connections to 1 per minute regardless of the reason of reconnection, but allow one immediate retry. This is more reliable than ratelimiting only in error conditions because ratelimiting can't be skipped by mistake. Anyway connections shouldn't be frequent in normal operation mode.
link2xt
approved these changes
Nov 30, 2023
Collaborator
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
LGTM, I also checked that configure() creates new IMAP clients for each tried host/port, so it will not be ratelimited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit the number of IMAP connections to 1 per minute regardless of the reason of reconnection, but allow one immediate retry. This is more reliable than ratelimiting only in error conditions because ratelimiting can't be skipped by mistake. Anyway connections shouldn't be frequent in normal operation mode.
Close #4940