fix: No new chats for MDNs with alias (#5196)#5199
Merged
Conversation
Septias
commented
Jan 20, 2024
Collaborator
Author
There was a problem hiding this comment.
@link2xt can you look over my test? I tried to create a scenario where Alice identifies as Alice Smith but sends a message overwritten with Alice Aris. Bob will then create a read receipt for Alice Aris which should then create a new chat on Alice's device. This does not happen yet and I don't understand why.
Collaborator
|
It is not about display name, display name does not matter at all when we decide if the mail is for us or not. |
Collaborator
Author
|
I don't manage to create a failing test |
Septias
requested review from
iequidoo and
link2xt
and removed request for
link2xt
added 2 commits
January 22, 2024 16:00
Septias
force-pushed
the
sk/fix_mdn_new_chat
branch
from
bc8d51f to
9e86176
Compare
link2xt
approved these changes
Jan 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #5196