api!: jsonrpc: device message api now requires Option<MessageData> instead of String for the message#5211
Merged
Simon-Laux merged 2 commits intomainfrom Jan 25, 2024
Conversation
…instead of `String` for the message api: jsonrpc: device message api now setting empty device messages to block adding a message for a specific label
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jan 24, 2024
closes #3637 depends on chatmail/core#5211
adzialocha
reviewed
Jan 24, 2024
iequidoo
approved these changes
Jan 24, 2024
Co-authored-by: iequidoo <117991069+iequidoo@users.noreply.github.com>
iequidoo
approved these changes
Jan 24, 2024
adzialocha
pushed a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Feb 1, 2024
closes #3637 depends on chatmail/core#5211
adzialocha
pushed a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Feb 1, 2024
closes #3637 depends on chatmail/core#5211
Simon-Laux
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Feb 3, 2024
* do not add changelog device message on fresh accounts closes #3637 depends on chatmail/core#5211 * changelog entry * apply code review suggestions * Remove dead code --------- Co-authored-by: adz <x12@adz.garden>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api: jsonrpc: device message api now setting empty device messages to block adding a message for a specific label
required for deltachat/deltachat-desktop#3639