Skip to content

fix pytest compat#5317

Merged
link2xt merged 1 commit intomainfrom
fix_pytest_compat
Mar 4, 2024
Merged

fix pytest compat#5317
link2xt merged 1 commit intomainfrom
fix_pytest_compat

Conversation

@hpk42
Copy link
Copy Markdown
Contributor

@hpk42 hpk42 commented Mar 4, 2024

seems pytest_report_header has changed with pytest incompatible but we don't need it anyway so we can just leave it out.

but we don't need it anyway so we can just leave it away
@hpk42
Copy link
Copy Markdown
Contributor Author

hpk42 commented Mar 4, 2024

the test failures are pretty sure unrelated. It's a trivial change that only depends on pytest (and the tests always use 8.1.0, so no variance there).

@link2xt link2xt merged commit 7cc2a09 into main Mar 4, 2024
@link2xt link2xt deleted the fix_pytest_compat branch March 4, 2024 15:58
@hpk42
Copy link
Copy Markdown
Contributor Author

hpk42 commented Mar 4, 2024

post scriptum: pytest devs yanked the 8.1.0 release which introduced the regression but this PR still makes sense.

link2xt pushed a commit that referenced this pull request Mar 4, 2024
seems pytest_report_header has changed with pytest incompatible but we
don't need it anyway so we can just leave it out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants