feat: Case-insensitive search for non-ASCII messages (#5052) #5321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Mar 5, 2024
Collaborator
|
Let's merge this after merging peerchannels. @Simon-Laux is running peerchannels PR with current account without a backup AFAIK, so rebasing peerchannel migration on top of this migration will cause troubles. |
Collaborator
|
Peerchannels are merged, so this needs a rebase now. |
iequidoo
force-pushed
the
iequidoo/case-insensitive-search
branch
from
079394d to
e38e21d
Compare
iequidoo
force-pushed
the
iequidoo/case-insensitive-search
branch
from
e38e21d to
db29f42
Compare
link2xt
approved these changes
Jun 17, 2024
SQLite search with `LIKE` is case-insensitive only for ASCII chars. To make it case-insensitive for all messages, create a new column `msgs.txt_normalized` defaulting to `NULL` (so we do not bump up the database size in a migration) and storing lowercased/normalized text there when the row is created/updated. When doing a search, search over `IFNULL(txt_normalized, txt)`.
iequidoo
force-pushed
the
iequidoo/case-insensitive-search
branch
from
db29f42 to
2bb2a0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite search with
LIKEis case-insensitive only for ASCII chars. To make it case-insensitive for all messages, create a new columnmsgs.txt_normalizeddefaulting toNULL(so we do not bump up the database size in a migration) and storing lowercased/normalized text there when the row is created/updated. When doing a search, search overIFNULL(txt_normalized, txt).Close #5052