Merged
Conversation
as turned out on recent researches wrt a slow database, setting `save_mime_headers` will result in 25x larger databases. this is definetely something we want to know at least in the debug info. (the option cannot be enabled in current UIs, however, esp. devs find options to set this. apart from that, save_mime_headers is only used in some python tests)
iequidoo
approved these changes
Mar 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as turned out on recent researches wrt a slow database, setting
save_mime_headerswill result in 25x larger databases.this is definetely something we want to know at least in the debug info.
(the option cannot be enabled in current UIs,
however, esp. devs find options to set this.
apart from that, save_mime_headers is only used in some python tests)
ftr: the huge database was more than 10 times slower, leading to missing notifications on ios (as things do not finish within the few seconds iOS gave us).
moreover, the hugeness also avoids exporting; this is fixed by #5349