fix: Create a group unblocked for bot even if 1:1 chat is blocked#5634
Merged
fix: Create a group unblocked for bot even if 1:1 chat is blocked#5634
Conversation
iequidoo
force-pushed
the
iequidoo/auto-accept-group-for-bot
branch
from
3d81555 to
956d805
Compare
iequidoo
force-pushed
the
iequidoo/auto-accept-group-for-bot
branch
from
956d805 to
76d4b47
Compare
iequidoo
force-pushed
the
iequidoo/auto-accept-group-for-bot
branch
from
76d4b47 to
1378201
Compare
Hocuri
approved these changes
Aug 16, 2024
Hocuri
force-pushed
the
iequidoo/auto-accept-group-for-bot
branch
from
1378201 to
fb84289
Compare
Collaborator
|
I rebased so that CI runs with the current tests |
iequidoo
force-pushed
the
iequidoo/auto-accept-group-for-bot
branch
from
fb84289 to
9af35fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs a test, the test in the first commit is unrelated.
@adbenitez, i can't reproduce #5514, the test in the first commit just works. Maybe you can clarify the scenario? Also you can try the fix from the second commit, though i'm unsure if the changed code is related to your scenario, this is the only place where a group request can be created for a bot.
EDIT: I've reproduced it and added a test to the second commit. @adbenitez, please check if it corresponds to your scenario.
Fix #5514