Merged
Conversation
Hocuri
force-pushed
the
hoc/correct-sanitizing-of-name-and-address
branch
4 times, most recently
from
027847a to
a7e066d
Compare
This was referenced Jun 19, 2024
Hocuri
force-pushed
the
hoc/correct-sanitizing-of-name-and-address
branch
2 times, most recently
from
ee77edb to
c20c5b1
Compare
Hocuri
changed the title
Hocuri
force-pushed
the
hoc/correct-sanitizing-of-name-and-address
branch
from
1edd193 to
318a1f1
Compare
iequidoo
reviewed
Jun 24, 2024
Collaborator
iequidoo
left a comment
iequidoo
left a comment
There was a problem hiding this comment.
Commit message: "refactor: add_or_lookup_contact_by_addr() is now the same as Contact::add_or_lookup() anD can be inlined"
…and remove newlines There is no reason why one would want to normalize a name but not remove RTLO characters
…ng all callers to do so
…:add_or_lookup() and can be inlined Contact::add_or_lookup() also returns ContactId::SELF if `addr` is the self addr
… name them consistently
It's already called via sanitize_name_and_addr()
Hocuri
force-pushed
the
hoc/correct-sanitizing-of-name-and-address
branch
from
318a1f1 to
2fe2eb2
Compare
iequidoo
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Best reviewed commit-by-commit; the commit messages explain what is done.